-
Notifications
You must be signed in to change notification settings - Fork 4
fix: use fastlz sizes for tracking da usage #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I have copied implementation of DA limit tracking from reth, do they have this issue too? |
@SozinM I believe Reth uses the fastlz size not the txn length (builder, txn, fastlz). Whereas currently we use transaction.length() , which I think is the uncompressed size. I'm not familiar with Reth, so my understanding of their implementation maybe wrong |
IMO it's better to keep code closer to the Reth -> we could copy their approach on fastlz |
We could just use chages from this PR https://github.com/paradigmxyz/reth/pull/16153/files from the file builder.rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to import reth_optimism_txpool::estimated_da_size::DataAvailabilitySized so we could call tx.estimated_da_size()
@SozinM nice find, looks like |
136f7ed
to
df07f77
Compare
I think you could rebase on this PR, i hope we will merge it soon #6, i solved all conflicts for the newer version |
Sure, will rebase this on main once your PR is merged. |
📝 Summary
Migrated from rbuilder PR flashbots/rbuilder#615
This PR has a couple of changes:
💡 Motivation and Context
Without this change:
✅ I have completed the following steps:
make lint
make test