Skip to content

feat: implement builder pattern for CustomOpPayloadBuilder #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

varun-doshi
Copy link

πŸ“ Summary

Implement proposer Builder pattern for CustomOpPayloadBuilder

πŸ’‘ Motivation and Context


Closes #504
To implement proposer Builder pattern for CustomOpPayloadBuilder

βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@SozinM
Copy link
Collaborator

SozinM commented Mar 26, 2025

@varun-doshi thanks! this is going in the right direction.

  1. There is 2 places when we build CustomOpPayloadBuilder - payload_builder_vanilla.rs and payload_builder.rs
  2. I was thinking of creating unified builder for both of them, call it like CustomOpPayloadBuilderBuilder and make all fields as optional
  3. Then we could build one or the other, depending on the feature
    that would be a good start imo

@varun-doshi
Copy link
Author

Got it...will make appropriate changes

@SozinM
Copy link
Collaborator

SozinM commented Mar 28, 2025

@ferranbt take a look at this pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Op-rbuilder refactor CustomOpPayloadBuilder
2 participants