Skip to content

record metrics on cancel #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

record metrics on cancel #579

wants to merge 1 commit into from

Conversation

jowparks
Copy link
Contributor

📝 Summary

💡 Motivation and Context

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@jowparks jowparks force-pushed the record-metrics-on-cancel branch from 9e20852 to 6d68edd Compare April 23, 2025 18:31
@jowparks jowparks force-pushed the record-metrics-on-cancel branch from 6d68edd to 074f0a6 Compare April 23, 2025 18:32
@jowparks jowparks marked this pull request as ready for review April 23, 2025 18:33
avalonche
avalonche approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@avalonche avalonche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a more robust implementation would be having the metrics returned from pub fn execute_best_transactions<DB>( and record the metrics when this function is called without considering all the extra code branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avalonche avalonche avalonche approved these changes

@dvush dvush Awaiting requested review from dvush dvush is a code owner

@ZanCorDX ZanCorDX Awaiting requested review from ZanCorDX ZanCorDX is a code owner

@ferranbt ferranbt Awaiting requested review from ferranbt ferranbt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jowparks @avalonche