Rebase on reth with pending pool fix #593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
requested review from
dvush,
ZanCorDX,
ferranbt and
metachris
as code owners
SozinM
force-pushed
the
msozin/op-rbuilder/pool-pending-fix
branch
from
44129a3 to
87d82f0
Compare
SozinM
force-pushed
the
msozin/op-rbuilder/pool-pending-fix
branch
from
6d56b43 to
386b427
Compare
|
Blocker for full integration test: paradigmxyz/reth#15973 |
avalonche
reviewed
Apr 28, 2025
| { | ||
| type PayloadBuilder = OpPayloadBuilderVanilla<Pool, Node::Provider>; | ||
|
|
||
| async fn build_payload_builder( | ||
| self, | ||
| ctx: &BuilderContext<Node>, | ||
| pool: Pool, | ||
| _evm_config: Evm, |
There was a problem hiding this comment.
why add evm config if it is not used?
There was a problem hiding this comment.
Because they changed the method signature in the new reth, and we implement reth trait
There was a problem hiding this comment.
what did they add it for? should our builder use the evm config from the arg as well?
avalonche
approved these changes
Apr 28, 2025
avalonche
reviewed
Apr 28, 2025
| let block_hash = generator.generate_block().await?; | ||
|
|
||
| // TODO: uncomment once reth issue is addressed https://github.com/paradigmxyz/reth/issues/15973 |
There was a problem hiding this comment.
does this affect pending / queued pool metrics in reth as well?
There was a problem hiding this comment.
metrics are fine (checked it)
Seems like only issue is on rpc call side
There was a problem hiding this comment.
okay, turned out that issue was with the test itself, found that problem and implementing the fix
SozinM
force-pushed
the
msozin/op-rbuilder/pool-pending-fix
branch
from
3b784b0 to
89a10ed
Compare
ferranbt
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Use new reth version
Bump rust to 1.86
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test