Skip to content

New competition bid source#674

Merged
ZanCorDX merged 22 commits into
developfrom
new-competition-bid-source
Aug 6, 2025
Merged

New competition bid source#674
ZanCorDX merged 22 commits into
developfrom
new-competition-bid-source

Conversation

@ZanCorDX

@ZanCorDX ZanCorDX commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator

📝 Summary

The whole pipeline has been updated to use BlockBid (all bids seen in all relays) instead CompetitionBid (single best bid to beat).
This change gives more information to the bidding service and implies that the SlotBidder is now just a UnfinishedBlockBuildingSink and the BiddingService gets all the bids by implemening BlockBidWithStatsObs

pub trait BlockBidWithStatsObs: Send + Sync {
    /// Be careful, we don't assume any kind of filtering here so bid may contain our own bids.
    fn update_new_bid(&self, bid_with_stats: BlockBidWithStats);
}

and is his responsibility to let the active bidders know about the competition bids.
The rbuilder now connects to the bid-scraper to get those BlockBid.
Some other changes:

  • ethers replaced by alloy
  • Some refactoring on crates/rbuilder/src/live_builder/config.rs to simplify the creation of other cfgs.
  • Some lint cleaning.

💡 Motivation and Context

Get rid of any external dependency to get competition bids.

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@ZanCorDX
ZanCorDX requested a review from bakhtin August 5, 2025 18:04
@ZanCorDX
ZanCorDX merged commit ac093f1 into develop Aug 6, 2025
3 checks passed
@ZanCorDX
ZanCorDX deleted the new-competition-bid-source branch August 6, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants