feat(metrics): add metric for builder proxy being up #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a metric, "rpc.builder_up" that indicates whether the builder proxy is responding to requests. If the builder proxy returns 500 Internal Server Error, the builder proxy is reported as down. Otherwise, the builder proxy is reported as up. This is a valuable feature for chain operators running rollup boost who need to track the status of the remote builder.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
I'm not sure this is any more useful than just keeping a histogram for builder responses with a status label attached. I would personally prefer that approach. There's already an open PR which includes this functionality as well. I believe this is in #135. |
|
Closing for now as metrics to track builder responses were included in #135. Feel free to open an issue if there are additional metrics that should be added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a metric, "rpc.builder_up" that indicates whether the builder proxy is responding to requests. If the builder proxy returns 500 Internal Server Error, the builder proxy is reported as down. Otherwise, the builder proxy is reported as up.
This is a valuable feature for chain operators running rollup boost who need to track the status of the remote builder.