-
Notifications
You must be signed in to change notification settings - Fork 35
feat: simplify ExecutionMode #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Thanks for opening this PR! In addition to the comments above can we also ensure that Rollup Boost does not forward Engine API requests to the builder when ExecutionMode is set to |
Latest Commit makes the following changes:
|
4b3914b
to
5f041dd
Compare
There's a failing test which says |
5f041dd
to
83edab4
Compare
83edab4
to
570b0e6
Compare
It looks like the test is failing because the way |
Thanks for the PR, LGTM! @ferranbt @avalonche any additional thoughts? Also it seems the Kurtosis CI keeps failing due to an issue with how Contender is being run. We can open a separate PR to fix this. |
@0xKitsune opened a PR to fix the stress test CI #204 |
Fixes #196
Changes made:
Fallback
mode fromExecutionMode
DryRun
mode will get bothl2_payload
andbuilder_payload
, but will always send thel2_payload
. This was different previously where in DryRun, the call tobuilder_payload
would return an error.