feat: process Engine API requests sequentially #201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
0xForerunner
approved these changes
May 7, 2025
Collaborator
0xForerunner
left a comment
0xForerunner
left a comment
There was a problem hiding this comment.
Nice! Super clean, looks good.
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #188, simplifies #192
This PR updates the ProxyService to process all Engine API requests sequentially. Instead of forwarding Engine requests directly to the inner service, they’re now enqueued along with a response channel, and a separate task processes the queue. This guarantees that Engine API calls are processed sequentially while still allowing all other RPC calls to be processed concurrently.