Call execution_mode only once in get_payload #245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
avalonche
approved these changes
May 22, 2025
0xKitsune
approved these changes
May 22, 2025
| @@ -654,7 +655,7 @@ impl RollupBoostServer { | |||
| self.probes.set_health(Health::Healthy); | |||
|
|
|||
| if let Ok(Some(payload)) = builder_payload { | |||
| if self.execution_mode().is_dry_run() { | |||
| if execution_mode.is_dry_run() { | |||
There was a problem hiding this comment.
There is an edge case here where execution mode is enabled when this function is invoked but later switched to DryRun before receiving the payloads. In this case, the builder block will be selected. If this is an acceptable edge case then lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.