Skip to content

Call execution_mode only once in get_payload #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ferranbt
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented May 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rollup-boost ⬜️ Ignored (Inspect) Visit Preview May 22, 2025 1:51pm

@@ -654,7 +655,7 @@ impl RollupBoostServer {
self.probes.set_health(Health::Healthy);

if let Ok(Some(payload)) = builder_payload {
if self.execution_mode().is_dry_run() {
if execution_mode.is_dry_run() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an edge case here where execution mode is enabled when this function is invoked but later switched to DryRun before receiving the payloads. In this case, the builder block will be selected. If this is an acceptable edge case then lgtm.

@ferranbt ferranbt closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants