-
Notifications
You must be signed in to change notification settings - Fork 929
feat: support mxfp4 & mxfp8 entrypoint for blackwell cutedsl dense gemm #2660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
flashinfer-bot
merged 8 commits into
flashinfer-ai:main
from
bzhng-development:brayden/mxfp4-blockscale-dense-gemm
Mar 6, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
73ab0bc
feat: Add mxfp4 blockscale dense gemm support
b8zhong c52ce25
fix: adjust alpha calculation for fp4 gemm
b8zhong 32f22d8
more
b8zhong fd9d432
more
b8zhong 949c488
more
b8zhong 6608b2f
more
b8zhong 0703627
more
b8zhong 59de382
more
b8zhong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why mxfp4 cutedsl backend have to be using a device tensor with value 1.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I removed it, I encountered some compilation relating to
make_fake_compact_tensor(cutlass.Float32, (1,)), as I believe they still share the exact same code path. To avoid touching too muchcute-dslwhich I am not super familiar with, I left it as passing it 1.0 for now. But I also think it can be removed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment something like
TODOso that in the future people could understand why you add this and we should get it removed in the future?