Skip to content

Conversation

@aaronk6
Copy link

@aaronk6 aaronk6 commented Sep 9, 2025

Update documentation: Clarify that http_proxy is not used for HTTPS requests

While experimenting with proxy settings in a Butane config, I noticed that https_proxy must be explicitly set for HTTPS requests to go through the proxy. Setting only http_proxy will proxy plain HTTP requests, but HTTPS requests still go out directly.

However, the documentation previously stated that http_proxy would also be used for HTTPS requests unless overridden by https_proxy. This is incorrect, as confirmed on Matrix.

This PR updates the documentation to reflect the actual behavior.

@aaronk6 aaronk6 requested a review from a team as a code owner September 9, 2025 19:15
* **_hash_** (string): the hash of the certificate, in the form `<type>-<value>` where type is either `sha512` or `sha256`.
* **_proxy_** (object): options relating to setting an `HTTP(S)` proxy when fetching resources.
* **_http_proxy_** (string): will be used as the proxy URL for HTTP requests and HTTPS requests unless overridden by `https_proxy` or `no_proxy`.
* **_http_proxy_** (string): will be used as the proxy URL for HTTP requests unless overridden by `no_proxy`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The Flatcar docs copy of the Ignition config spec also needs to be fixed.

Also, we should do the same change upstream in the Ignition specs and Butane specs (linked specific files here but there's a copy for each variant/version):
https://github.com/coreos/ignition/blob/main/docs/configuration-v3_6_experimental.md
https://github.com/coreos/butane/blob/main/docs/config-flatcar-v1_2-exp.md

@aaronk6
Copy link
Author

aaronk6 commented Sep 10, 2025

Thanks. The Flatcar docs copy of the Ignition config spec also needs to be fixed.

Oh, missed that. Just updated my PR.

Also, we should do the same change upstream in the Ignition specs and Butane specs (linked specific files here but there's a copy for each variant/version)

I’ll look into this, too.

Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, I wonder if we should wait until this is also merged upstream (Butane and Ignition repos) or it might get overwritten once we need to sync a newer version of the specs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Testing / in Review

Development

Successfully merging this pull request may close these issues.

2 participants