-
Notifications
You must be signed in to change notification settings - Fork 30
MetaInfo: Don't start with an article #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
One of the [Flathub MetaInfo Quality Guidelines][1] Chrome is currently failing is its summary starts with an article. These guidelines should be followed for improved display across Flathub. This PR reworks the summary, adapting copy from the Chrome app listing for Android while: - Not repeating the developer name - Keeping it under 35 characters [1]: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines
Started test build 116432 |
Build 116432 successful
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks goody, but would add 'by Google' or 'from Google'
To clarify the origin of the software.
Should be 35 characters or less.
The summary is not to communicate the developer or origin; that’s precisely what the
I think it’s clear it is from Google. 😅 ¹https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#name-summary-and-developer-name |
These files were taken from upstream (ditto for the one in Chromium), are these things that should be pushed up there as well? |
@refi64 yeah that's fair; I've not contributed to Chromium so idk if I'll find the time to contribute that but it should definitely go upstream if possible. |
One of the Flathub MetaInfo Quality Guidelines Chrome is currently failing is its summary starts with an article. These guidelines should be followed for improved display across Flathub.
This PR reworks the summary, adapting copy from the Chrome app listing for Android while: