[fix] TypeError: Object.defineProperties called on non-object (issue #166) by shihshen · Pull Request #260 · flatiron/cradle

shihshen · 2014-10-29T11:52:39Z

The original code doesn't really fix the issue #166 .

…166)

indexzero · 2014-11-07T19:52:59Z

lgtm, but could we get a test for this because I'm not exactly sure what you're fixing in #166.

shihshen · 2014-11-08T07:08:47Z

Good idea. Let me add a test for this.

shihshen · 2014-12-26T06:47:31Z

lib/cradle.js

typeof body is "string", but body.error exist. body is got from request module.

body {
width: 100% !important; min-width: 100%; -webkit-text-size-adjust: 100%; -ms-text-size-adjust: 100%; margin: 0; padding: 0;
}
.ExternalClass {
width: 100%;
}
.ExternalClass {
line-height: 100%;
}
#backgroundTable {
margin: 0; padding: 0; width: 100% !important; line-height: 100% !important;
}
img {
outline: none; text-decoration: none; -ms-interpolation-mode: bicubic; width: auto; max-width: 100%; float: left; clear: both; display: block;
}
body {
color: #222222; font-family: "Helvetica", "Arial", sans-serif; font-weight: normal; padding: 0; margin: 0; text-align: left; line-height: 1.3;
}
body {
font-size: 14px; line-height: 19px;
}
a:hover {
color: #2795b6 !important;
}
a:active {
color: #2795b6 !important;
}
a:visited {
color: #2ba6cb !important;
}
h1 a:active {
color: #2ba6cb !important;
}
h2 a:active {
color: #2ba6cb !important;
}
h3 a:active {
color: #2ba6cb !important;
}
h4 a:active {
color: #2ba6cb !important;
}
h5 a:active {
color: #2ba6cb !important;
}
h6 a:active {
color: #2ba6cb !important;
}
h1 a:visited {
color: #2ba6cb !important;
}
h2 a:visited {
color: #2ba6cb !important;
}
h3 a:visited {
color: #2ba6cb !important;
}
h4 a:visited {
color: #2ba6cb !important;
}
h5 a:visited {
color: #2ba6cb !important;
}
h6 a:visited {
color: #2ba6cb !important;
}
table.button:hover td {
background: #2795b6 !important;
}
table.button:visited td {
background: #2795b6 !important;
}
table.button:active td {
background: #2795b6 !important;
}
table.button:hover td a {
color: #fff !important;
}
table.button:visited td a {
color: #fff !important;
}
table.button:active td a {
color: #fff !important;
}
table.button:hover td {
background: #2795b6 !important;
}
table.tiny-button:hover td {
background: #2795b6 !important;
}
table.small-button:hover td {
background: #2795b6 !important;
}
table.medium-button:hover td {
background: #2795b6 !important;
}
table.large-button:hover td {
background: #2795b6 !important;
}
table.button:hover td a {
color: #ffffff !important;
}
table.button:active td a {
color: #ffffff !important;
}
table.button td a:visited {
color: #ffffff !important;
}
table.tiny-button:hover td a {
color: #ffffff !important;
}
table.tiny-button:active td a {
color: #ffffff !important;
}
table.tiny-button td a:visited {
color: #ffffff !important;
}
table.small-button:hover td a {
color: #ffffff !important;
}
table.small-button:active td a {
color: #ffffff !important;
}
table.small-button td a:visited {
color: #ffffff !important;
}
table.medium-button:hover td a {
color: #ffffff !important;
}
table.medium-button:active td a {
color: #ffffff !important;
}
table.medium-button td a:visited {
color: #ffffff !important;
}
table.large-button:hover td a {
color: #ffffff !important;
}
table.large-button:active td a {
color: #ffffff !important;
}
table.large-button td a:visited {
color: #ffffff !important;
}
table.secondary:hover td {
background: #d0d0d0 !important; color: #555;
}
table.secondary:hover td a {
color: #555 !important;
}
table.secondary td a:visited {
color: #555 !important;
}
table.secondary:active td a {
color: #555 !important;
}
table.success:hover td {
background: #457a1a !important;
}
table.alert:hover td {
background: #970b0e !important;
}
body.outlook p {
display: inline !important;
}
body {
color: #222222; font-family: "Verdana", "Helvetica", "Arial", sans-serif;
}
.rating a:active {
text-decoration: underline; color: #ffffff !important;
}
.rating a:visited {
text-decoration: underline; color: #ffffff !important;
}
.rating a:hover {
color: #000000 !important;
}
@media only screen and (max-width: 600px) {
table[class="body"] img {
width: auto !important; height: auto !important;
}
table[class="body"] center {
min-width: 0 !important;
}
table[class="body"] .container {
width: 95% !important;
}
table[class="body"] .row {
width: 100% !important; display: block !important;
}
table[class="body"] .wrapper {
display: block !important; padding-right: 0 !important;
}
table[class="body"] .columns {
table-layout: fixed !important; float: none !important; width: 100% !important; padding-right: 0px !important; padding-left: 0px !important; display: block !important;
}
table[class="body"] .column {
table-layout: fixed !important; float: none !important; width: 100% !important; padding-right: 0px !important; padding-left: 0px !important; display: block !important;
}
table[class="body"] .wrapper.first .columns {
display: table !important;
}
table[class="body"] .wrapper.first .column {
display: table !important;
}
table[class="body"] table.columns td {
width: 100% !important;
}
table[class="body"] table.column td {
width: 100% !important;
}
table[class="body"] .columns td.one {
width: 8.333333% !important;
}
table[class="body"] .column td.one {
width: 8.333333% !important;
}
table[class="body"] .columns td.two {
width: 16.666666% !important;
}
table[class="body"] .column td.two {
width: 16.666666% !important;
}
table[class="body"] .columns td.three {
width: 25% !important;
}
table[class="body"] .column td.three {
width: 25% !important;
}
table[class="body"] .columns td.four {
width: 33.333333% !important;
}
table[class="body"] .column td.four {
width: 33.333333% !important;
}
table[class="body"] .columns td.five {
width: 41.666666% !important;
}
table[class="body"] .column td.five {
width: 41.666666% !important;
}
table[class="body"] .columns td.six {
width: 50% !important;
}
table[class="body"] .column td.six {
width: 50% !important;
}
table[class="body"] .columns td.seven {
width: 58.333333% !important;
}
table[class="body"] .column td.seven {
width: 58.333333% !important;
}
table[class="body"] .columns td.eight {
width: 66.666666% !important;
}
table[class="body"] .column td.eight {
width: 66.666666% !important;
}
table[class="body"] .columns td.nine {
width: 75% !important;
}
table[class="body"] .column td.nine {
width: 75% !important;
}
table[class="body"] .columns td.ten {
width: 83.333333% !important;
}
table[class="body"] .column td.ten {
width: 83.333333% !important;
}
table[class="body"] .columns td.eleven {
width: 91.666666% !important;
}
table[class="body"] .column td.eleven {
width: 91.666666% !important;
}
table[class="body"] .columns td.twelve {
width: 100% !important;
}
table[class="body"] .column td.twelve {
width: 100% !important;
}
table[class="body"] td.offset-by-one {
padding-left: 0 !important;
}
table[class="body"] td.offset-by-two {
padding-left: 0 !important;
}
table[class="body"] td.offset-by-three {
padding-left: 0 !important;
}
table[class="body"] td.offset-by-four {
padding-left: 0 !important;
}
table[class="body"] td.offset-by-five {
padding-left: 0 !important;
}
table[class="body"] td.offset-by-six {
padding-left: 0 !important;
}
table[class="body"] td.offset-by-seven {
padding-left: 0 !important;
}
table[class="body"] td.offset-by-eight {
padding-left: 0 !important;
}
table[class="body"] td.offset-by-nine {
padding-left: 0 !important;
}
table[class="body"] td.offset-by-ten {
padding-left: 0 !important;
}
table[class="body"] td.offset-by-eleven {
padding-left: 0 !important;
}
table[class="body"] table.columns td.expander {
width: 1px !important;
}
table[class="body"] .right-text-pad {
padding-left: 10px !important;
}
table[class="body"] .text-pad-right {
padding-left: 10px !important;
}
table[class="body"] .left-text-pad {
padding-right: 10px !important;
}
table[class="body"] .text-pad-left {
padding-right: 10px !important;
}
table[class="body"] .hide-for-small {
display: none !important;
}
table[class="body"] .show-for-desktop {
display: none !important;
}
table[class="body"] .show-for-small {
display: inherit !important;
}
table[class="body"] .hide-for-desktop {
display: inherit !important;
}
}
@media screen {
@font-face {
font-family: 'Roboto Slab'; font-style: normal; font-weight: 700; src: local('Roboto Slab Bold'), local('RobotoSlab-Bold'), url(http://themes.googleusercontent.com/static/fonts/robotoslab/v3/dazS1PrQQuCxC3iOAJFEJRbnBKKEOwRKgsHDreGcocg.woff) format('woff');
}
}

Email Delivery Failure Notice What Happened? There was an issue delivering your message to: shock@aurasw.com Why? The domain name of the email address is not valid Advertisement | Prefer no ads? What's next? Check the "aurasw.com" part of the email address for misspellings or missing letters. (If you find an error, you might need to correct it in your contacts list or address book too.) If necessary, contact your recipient another way (e.g., phone or text message) to confirm their email address. Prefer step by step assistance? Learn more about this bounce message Rate this email: Helpful Somewhat helpful Not helpful bounce.io 908 Main Street, Suite 360, Louisville, Colorado Copyright © 2014 bounce.io, All rights reserved. Help

shihshen · 2014-12-26T06:52:36Z

Hi indexzero,
I have some difficulty to write a test for this case. Check out the "Files Changed" tab. The body from request module is string, but with a property error. I am not sure why yet. It might be a issue of request module, but it would be better to do some check here. And this change also remove some redundant code.

phillipadsmith · 2016-06-30T00:26:17Z

Howdy All,

I'm not sure what's up with this PR?

Basically, if I install Winston for logging, and able the default CouchDB logger via winston-couchdb, which uses this library, I immediately get the error "TypeError: Object.defineProperties called on non-object" that is fixed by this PR.

Any chance of getting the basic fix for this issue merged?

Phillip.

shihshen · 2016-06-30T02:15:30Z

Hi Phillip,
Maybe you can help to write some tests for this PR?

phillipadsmith · 2016-06-30T03:08:32Z

Maybe you can help to write some tests for this PR?

Looking at the diff, I don't see anything that would require a test (or a new test): from what I can see, you've simply re-factored the code to actually work with the response that's received. What would the test be trying to assert?

Powpow Shen added 2 commits October 29, 2014 19:28

[fix] TypeError: Object.defineProperties called on non-object (issue #…

dc0f19f

…166)

[fix] TypeError: Object.defineProperties called on non-object (issue #…

8bafe85

…166)

cvdi added 2 commits December 26, 2014 00:54

Remove unecessary condition block.

cbba8ee

Refactor.

5103368

shihshen reviewed Dec 26, 2014
View reviewed changes

shihshen mentioned this pull request Jan 16, 2016

TypeError: Object.defineProperties called on non-object #166

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix] TypeError: Object.defineProperties called on non-object (issue #166)#260

[fix] TypeError: Object.defineProperties called on non-object (issue #166)#260
shihshen wants to merge 4 commits intoflatiron:masterfrom
shihshen:master

shihshen commented Oct 29, 2014

Uh oh!

indexzero commented Nov 7, 2014

Uh oh!

shihshen commented Nov 8, 2014

Uh oh!

shihshen Dec 26, 2014

Uh oh!

ShockUtility Dec 26, 2014

Uh oh!

shihshen commented Dec 26, 2014

Uh oh!

phillipadsmith commented Jun 30, 2016

Uh oh!

shihshen commented Jun 30, 2016

Uh oh!

phillipadsmith commented Jun 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

shihshen commented Oct 29, 2014

Uh oh!

indexzero commented Nov 7, 2014

Uh oh!

shihshen commented Nov 8, 2014

Uh oh!

shihshen Dec 26, 2014

Choose a reason for hiding this comment

Uh oh!

ShockUtility Dec 26, 2014

Choose a reason for hiding this comment

Uh oh!

shihshen commented Dec 26, 2014

Uh oh!

phillipadsmith commented Jun 30, 2016

Uh oh!

shihshen commented Jun 30, 2016

Uh oh!

phillipadsmith commented Jun 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants