[FEAT] Move numerical test and adapt to diverged functions #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtang8
commented
Nov 4, 2025
| log_likelihood_msdw = ill_kernel( | ||
| Iss, | ||
| n_pixels_phys, | ||
| images.phys_grid.n_pixels_total, |
Author
There was a problem hiding this comment.
request n_pixels_total only when likelihood is requested
wstangfi
reviewed
Nov 4, 2025
| Iyy_msdw, | ||
| Ixy_msdw | ||
| ) | ||
| log_likelihood_ms = torch.logsumexp(log_likelihood_msdw, dim = (2, 3)) |
Collaborator
There was a problem hiding this comment.
marginalize from msdw to ms outside of ill_kernel to give access to log_likelihood_msdw
wstangfi
reviewed
Nov 4, 2025
Collaborator
There was a problem hiding this comment.
numerical likelihood test
wstangfi
reviewed
Nov 4, 2025
Collaborator
There was a problem hiding this comment.
maybe I should use the new refactored cross_correlation_fixtures... either way works
Collaborator
There was a problem hiding this comment.
might be easier to use my version of the fixtures (I did some refactoring for clarity)
Collaborator
|
Tests work and ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocate a numerical test and modify it to accommodate changes in function definitions.