Skip to content

Conversation

@vncntprvst
Copy link
Contributor

Modify file handling to use copy on Windows.
Tested and working - but then we get an extra copy of the original file. Also, no idea where the temp file is.
Could it be done in-place instead?

Modify file handling to use copy on Windows.
Could it be done in-place instead?
@magland
Copy link
Collaborator

magland commented Sep 13, 2025

Thanks. It could be done in place, but you'd need to serve the parent directory. I opted not to do that because it could be a security risk. Wouldn't be too hard to make that an option... lmk if you want me to do that.

In the meantime, I'll merge this.

@magland magland merged commit cba54a3 into flatironinstitute:main-v2 Sep 13, 2025
3 of 5 checks passed
@magland
Copy link
Collaborator

magland commented Sep 13, 2025

released in neurosift 0.2.15

@vncntprvst
Copy link
Contributor Author

Thanks! I think it's ok to use copy, if serving the parent directory is a security risk. The copy is quite fast. The temp directory is written in the terminal, but maybe the location of the copy should be more explicit (it's in a view_nwb_<###> folder in C:\Users\<USERNAME>\AppData\Local\Temp)? Perhaps just add some info in the readme file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants