chore: bump emscripten docker image version #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey, smaller payload is always good... I've rerun all of the examples comparing live against a local compilation server and the current public server. No compilation or execution errors. Results seem to be generally in line with each other (though I didn't do some kind of statistical analysis, just eyeballing the parameters--but the top lines are all within less than a percent of each other with default settings.) I don't think a compilation performance test would be particularly meaningful given the different hardware involved (plus I'm getting cache hits from the public server) but performance for the local seemed acceptable. I don't see any blockers here--feel free to merge & deploy, and we can always roll it back. |
jsoules
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, none of the changes directly affect us in terms of needing to update our code, but the built wasm does get 5-10% smaller just by updating.