Skip to content

Conversation

@salim-b
Copy link
Contributor

@salim-b salim-b commented Mar 19, 2025

I think it makes sense to explicitly mention this since it's kinda counterintuitive to what one might expect.

@TingPing TingPing merged commit d2abdda into flatpak:main Mar 20, 2025
5 checks passed
@TingPing
Copy link
Member

Its harmless for this specific option so I don't mind, but its more of a general concept that module scopes are isolated. Only the global one is inherited.

@salim-b salim-b deleted the patch-1 branch March 20, 2025 15:23
salim-b added a commit to salim-b/flatpak-builder that referenced this pull request Mar 20, 2025
@salim-b
Copy link
Contributor Author

salim-b commented Mar 20, 2025

but its more of a general concept that module scopes are isolated

See #637 for a follow-up addition.

Another question: Would it be possible somehow to display a table of contents for the "Command Reference" pages, i.e. have a floating "On this page" ToC on the right side of the rendered page? Without it, it's really hard to keep an overview...

bbhtt pushed a commit that referenced this pull request Sep 2, 2025
* docs: Be explicit about module scope isolation

Follow-up to #636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants