This repository was archived by the owner on Sep 7, 2021. It is now read-only.
Pin Alpine version and force clean build context #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some OLCI image build applications like `buildah` and `podman` that do not respect `.dockerignore`. If the build context is initialized with a locally built `./artifacts` folder, there might be a libc / musl mismatch, and the integration tests will fail with `file not found`. This commit ensures the build context is cleaned on every image build, ensuring the binaries are rebuilt, and built against the right dynamic link. The commit also pins the Alpine image version, and thus pins the musl version that both the build and runtime images will use.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some OCI image build applications like
buildahandpodmanthat do not respect.dockerignore. If the build context is initialized with a locally built./artifactsfolder, there might be alibc/muslmismatch, and the integration tests will fail withfile not found.This commit ensures the build context is cleaned on every image build, ensuring the binaries in the
artifactsfolder are rebuilt, and built against the right dynamic link. The commit also pins the Alpine image version, and thus pins themuslversion that to be shared across the build and runtime images.