fix: terminal/browser panels open behind agent panel in single mode#193
Merged
Conversation
…cons The folder/terminal/browser icons in the project header used opacity-50 + group-hover:opacity-100, causing all three to fade in together when hovering anywhere on the project row. Switch to per-icon hover only so each icon behaves like every other icon button in the app. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
1 issue found across 33 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/desktop/tabler-icons-mock.ts">
<violation number="1" location="packages/desktop/tabler-icons-mock.ts:85">
P2: Duplicate mock.module registration for the same worker module creates unnecessary maintenance risk</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| Drawer: mockPrimitive, | ||
| })); | ||
|
|
||
| mock.module("@pierre/diffs/worker/worker.js?worker&url", () => ({ |
There was a problem hiding this comment.
P2: Duplicate mock.module registration for the same worker module creates unnecessary maintenance risk
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/desktop/tabler-icons-mock.ts, line 85:
<comment>Duplicate mock.module registration for the same worker module creates unnecessary maintenance risk</comment>
<file context>
@@ -82,51 +82,8 @@ mock.module("vaul-svelte", () => ({
- box: runedState,
- watcher: runedNoop,
- AnimationFrames: class {},
+mock.module("@pierre/diffs/worker/worker.js?worker&url", () => ({
+ default: "/mock-pierre-worker.js",
}));
</file context>
Tip: Review your code locally with the cubic CLI to iterate faster.
|
You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment |
f9d82cf to
82f9fc4
Compare
Terminal and browser panels are stored outside workspacePanels but three key mechanisms only checked workspacePanels when resolving fullscreen targets: - topLevelPanelsWithProject in panels-container missed terminal/browser panels, so view-mode state fell back to the agent panel as fullscreen target, hiding non-agent panels via isAgentFullscreenActive. - isTopLevelFullscreenTarget didn't recognize terminal/browser IDs, routing them to fullscreenPanelId instead of the single-mode path. - focusOpenedTopLevelPanel couldn't resolve project paths for terminal/browser panels, leaving focusedViewProjectPath unset. Add terminal and browser panels to all three sites and extract resolveTopLevelPanelProjectPath helper for unified lookup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Terminal and browser panels now open correctly in single-panel view mode instead of being hidden behind the agent panel. A secondary fix removes the group-hover fade effect on project header action icons so each icon highlights independently.
What changed
Panel store: terminal/browser as first-class top-level panels (
panel-store.svelte.ts)Terminal and browser panels are stored outside
workspacePanels, but 3 key mechanisms only checkedworkspacePanelswhen resolving targets:isTopLevelFullscreenTarget— didn't recognize terminal/browser panel IDs, routing them through the wrong fullscreen path.focusOpenedTopLevelPanel— couldn't resolve project paths for terminal/browser panels, leavingfocusedViewProjectPathunset and the panel invisible.topLevelPanelsWithProjectinpanels-container.svelte— missed terminal/browser panels entirely, so single-mode view state fell back to the agent panel as fullscreen target.All 3 sites now include terminal and browser panels. A new
resolveTopLevelPanelProjectPathhelper unifies the project-path lookup across workspace, terminal, and browser panels.Project header icon hover (
session-list-ui.svelte)projectHeaderHoverActionButtonClasspreviously usedopacity-50 group-hover:opacity-100, causing all 3 folder/terminal/browser icons to fade in together on row hover. Now each icon uses only per-iconhover:bg-accent hover:text-foreground, matching the rest of the app's icon hover behavior.transition-allnarrowed totransition-colors.CI note
The
FrontendCI job fails onmain(pre-existingruned/bun-testESM resolution issue). Unrelated to this PR.