Fixed App.js _SOCKET_HOST and _SOCKET_PORT unused#51
Closed
ingrdv2020 wants to merge 1 commit intofleetbase:mainfrom
Closed
Fixed App.js _SOCKET_HOST and _SOCKET_PORT unused#51ingrdv2020 wants to merge 1 commit intofleetbase:mainfrom
ingrdv2020 wants to merge 1 commit intofleetbase:mainfrom
Conversation
UnitedSystemaTech
approved these changes
Sep 9, 2024
Member
|
Fixed in version 2 refactor which will release this week #54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in main App.js, in setFleetbaseConfig, socketcluster_host and socketcluster_port were stored on _SOCKET_HOST and _SOCKET_PORT entries, but later in /features/shared/ConfigScreen.js the values retrieved are _SOCKETCLUSTER_HOST and _SOCKETCLUSTER_PORT, so those external link parameters were never used. This results in a mixed setting, and login with private deployment is not working using the link.