fix(tfvalidate): remove harden security restriction for community/enterprise#180
Open
billyjbryant wants to merge 3 commits into
Open
fix(tfvalidate): remove harden security restriction for community/enterprise#180billyjbryant wants to merge 3 commits into
billyjbryant wants to merge 3 commits into
Conversation
…out a community edition or enterprise agreement
billyjbryant
requested review from
a team,
ddribeiro and
edwardsb
as code owners
Contributor
|
Thank you for the submission. I am going to look at updating the PR to allow us to optionally still use the harden runner but to still allow any Forks to bypass it if specific conditions are not present. Hopefully this will meet your needs while not changing functionality on our end. |
- Make step-security/harden-runner optional via vars.TFVALIDATE_USE_HARDEN_RUNNER - Add PR comment with validation status using peter-evans/find-comment and create-or-update-comment - Build comment body with gh/jq in tfvalidate job step
Author
I made a few changes, let me know if that works for you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using the
harden-runneraction requires a license seat with Step Security's platform. For those that do not have this, the automations featured here will fail. This PR disables this action step by default.For those that do have Step Security, it can be easily re-enabled by adding a Repository Variable of
TFVALIDATE_USE_HARDEN_RUNNERwith a value oftrueto the GitHub repository.The PR also adds a visual for the TFValidate on the PR as a comment and updates the versions of all action includes.
Changes
Testing
**.tfpaths change.