[codex] Add h2c bulk backend for GCP installer transfers#234
Open
robbiet480 wants to merge 1 commit into
Open
Conversation
Contributor
|
@robbiet480 Thank you for your contribution! We'll schedule the review of your proposed changes for next sprint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cloud Run's HTTP/1 request body and non-streaming response limits make large Fleet software installer upload/download paths fail unless the whole Fleet service is forced to h2c. That global workaround breaks connection upgrades, which affects WebSocket-dependent Fleet features.
This adds a second Cloud Run service for large software installer transfer paths and forces only that service to h2c. The primary Fleet service remains on the existing
fleet_config.use_h2csetting, so normal UI/API/WebSocket traffic can stay on HTTP/1 while byte-heavy package paths route through the h2c backend.Changes
fleet-api-bulkCloud Run service using the same image, service account, VPC, resources, and secrets as the primary Fleet service, withFLEET_SERVER_FORCE_H2C=trueand an h2c container port.Validation
terraform fmt gcp/byo-project/cloud_run.tf gcp/byo-project/loadbalancer.tfterraform -chdir=gcp validate