Add scheduled reports for ai tooling#48939
Conversation
harrisonravazzolo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
harrisonravazzolo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
WalkthroughThis pull request adds a new YAML report file, ai-tool-detection.yml, under it-and-security/lib/all/reports/. It defines two osquery-based automation tasks: one collecting installed VS Code/IDE extensions per user on macOS, and another detecting Model Context Protocol (MCP) client configurations across multiple applications (Cursor, Claude Desktop, Claude Code, VS Code extensions, Gemini CLI, LMStudio) on macOS, Windows, and Linux by reading configuration files and extracting server entries via JSON parsing. The new report is registered in the testing-and-qa.yml fleet configuration's reports list. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@it-and-security/lib/all/reports/ai-tool-detection.yml`:
- Around line 69-76: The config_files CTE currently builds contents with
group_concat(f.line, '') in an undefined row order, which can scramble
reconstructed JSON. Update the aggregation in config_files to enforce
deterministic line ordering using the per-file line index available in the
query, or use SQLite’s ORDER BY within group_concat if supported, so the
downstream json_extract and json_each logic always receives valid JSON.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b940bccf-1f93-4d14-b822-d27ada71ea9c
📒 Files selected for processing (2)
it-and-security/fleets/testing-and-qa.ymlit-and-security/lib/all/reports/ai-tool-detection.yml
| config_files AS ( | ||
| SELECT | ||
| f.path, | ||
| group_concat(f.line, '') AS contents | ||
| FROM file_lines f | ||
| JOIN full_paths fp ON f.path = fp.full_path | ||
| GROUP BY f.path | ||
| ) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🌐 Web query:
sqlite group_concat aggregation order guarantee ORDER BY
💡 Result:
In SQLite, the group_concat function does not provide an inherent guarantee of order [1][2]. Without an explicit ORDER BY clause, the order of elements concatenated by group_concat is considered arbitrary and may depend on the order in which rows are processed, which can change between different queries or database states [3][2]. To ensure a specific order for the concatenated results, you should use the ORDER BY clause within the group_concat function, which was introduced to allow control over the input sequence for aggregation [2]. The syntax for using ordered group_concat is as follows [2]: SELECT group_concat(column_name, ',') ORDER BY column_name FROM table_name GROUP BY grouping_column; Alternatively, if you are using an older version of SQLite that does not support the ORDER BY clause within the aggregate function, or if you need to ensure consistent ordering across multiple concatenated columns, the standard practice is to perform the sorting in a subquery or Common Table Expression (CTE) [4][3]: SELECT grouping_column, group_concat(column_name) FROM ( SELECT grouping_column, column_name FROM table_name ORDER BY grouping_column, column_name) GROUP BY grouping_column; This approach ensures that the database processes the rows in the desired order before the aggregation occurs, guaranteeing consistent output [3].
Citations:
- 1: https://sqlite.org/lang_aggfunc.html
- 2: https://www3.sqlite.org/lang_aggfunc.html
- 3: https://stackoverflow.com/questions/44715333/in-sqlite-will-multiple-colums-order-the-same-way-with-group-concat
- 4: https://stackoverflow.com/questions/1897352/sqlite-group-concat-ordering
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the target file around the reported lines.
FILE="it-and-security/lib/all/reports/ai-tool-detection.yml"
wc -l "$FILE"
sed -n '1,140p' "$FILE" | cat -n
# Look for the `file_lines` CTE/source and any ordering applied before `group_concat`.
rg -n "file_lines|group_concat|ORDER BY|line" it-and-security/lib/all/reports/ai-tool-detection.ymlRepository: fleetdm/fleet
Length of output: 1949
Add an explicit order to group_concat
group_concat(f.line, '') depends on SQLite’s row order, which is arbitrary unless the input is ordered. If the lines are concatenated out of sequence, the reconstructed JSON becomes invalid and the downstream json_extract/json_each calls fail. Order by a per-file line index here, or use ORDER BY inside the aggregate on SQLite versions that support it.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@it-and-security/lib/all/reports/ai-tool-detection.yml` around lines 69 - 76,
The config_files CTE currently builds contents with group_concat(f.line, '') in
an undefined row order, which can scramble reconstructed JSON. Update the
aggregation in config_files to enforce deterministic line ordering using the
per-file line index available in the query, or use SQLite’s ORDER BY within
group_concat if supported, so the downstream json_extract and json_each logic
always receives valid JSON.
1 participant
Summary by CodeRabbit