Fix test setting flag that caused further tests to fail#48947
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48947 +/- ##
=======================================
Coverage 68.11% 68.11%
=======================================
Files 3709 3709
Lines 235099 235142 +43
Branches 12464 12464
=======================================
+ Hits 160129 160172 +43
- Misses 60594 60595 +1
+ Partials 14376 14375 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
WalkthroughThis pull request adds a new integration test, TestInstallAllSelfServiceSoftware, to server/service/integration_mdm_test.go. The test introduces helper closures for queuing software installs, querying installer state, creating scoped software installers, and completing install results. It sets up a mock Apple VPP HTTP server and MDM-enrolled host creation helpers, then exercises the install_all device endpoint across subtests covering install status/ordering, coexistence with concurrent activities, category/label/team scoping, and multi-host scenarios. Corresponding import and spacing adjustments were made in server/service/integration_enterprise_test.go with no logic changes. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.44.1)server/service/integration_mdm_test.goast-grep timed out on this file Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Related issue: Resolves #
Moves
TestInstallAllSelfServiceSoftwarefrom the enterprise integration suite (TestIntegrationsEnterprise) to the MDM integration suite (TestIntegrationsMDM), because setting theMDM.EnabledAndConfiguredflag in the enterprise suite was leaking into and failing other tests (TestLinuxDiskEncryption,TestTeamEndpoints,TestTeamSpecs,TestMDMNotConfiguredEndpoints,TestVPPAppsWithoutMDM,TestOrbitSetupExperienceStatusChecksAuthBeforeMDM).Checklist for submitter
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually
Summary by CodeRabbit