Skip to content

Fix test setting flag that caused further tests to fail#48947

Open
jkatz01 wants to merge 1 commit into
mainfrom
fix-vpp-install-all-suite-test
Open

Fix test setting flag that caused further tests to fail#48947
jkatz01 wants to merge 1 commit into
mainfrom
fix-vpp-install-all-suite-test

Conversation

@jkatz01

@jkatz01 jkatz01 commented Jul 8, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #
Moves TestInstallAllSelfServiceSoftware from the enterprise integration suite (TestIntegrationsEnterprise) to the MDM integration suite (TestIntegrationsMDM), because setting the MDM.EnabledAndConfigured flag in the enterprise suite was leaking into and failing other tests (TestLinuxDiskEncryption, TestTeamEndpoints, TestTeamSpecs, TestMDMNotConfiguredEndpoints, TestVPPAppsWithoutMDM, TestOrbitSetupExperienceStatusChecksAuthBeforeMDM).

Checklist for submitter

Testing

Summary by CodeRabbit

  • Tests
    • Expanded integration coverage for self-service software installs across team, label, category, and multi-host scenarios.
    • Added checks for install ordering, idempotency, queue consistency, and concurrent requests.
    • Included coverage for VPP-backed apps and mixed install queues to better validate real-world behavior.

@jkatz01 jkatz01 marked this pull request as ready for review July 8, 2026 15:28
@jkatz01 jkatz01 requested a review from a team as a code owner July 8, 2026 15:28
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.11%. Comparing base (2a1f513) to head (7ad6c6c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #48947   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files        3709     3709           
  Lines      235099   235142   +43     
  Branches    12464    12464           
=======================================
+ Hits       160129   160172   +43     
- Misses      60594    60595    +1     
+ Partials    14376    14375    -1     
Flag Coverage Δ
backend 69.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 00df7683-0eef-4dce-a900-11896efdda2d

📥 Commits

Reviewing files that changed from the base of the PR and between 9587374 and 7ad6c6c.

📒 Files selected for processing (2)
  • server/service/integration_enterprise_test.go
  • server/service/integration_mdm_test.go
💤 Files with no reviewable changes (1)
  • server/service/integration_enterprise_test.go

Walkthrough

This pull request adds a new integration test, TestInstallAllSelfServiceSoftware, to server/service/integration_mdm_test.go. The test introduces helper closures for queuing software installs, querying installer state, creating scoped software installers, and completing install results. It sets up a mock Apple VPP HTTP server and MDM-enrolled host creation helpers, then exercises the install_all device endpoint across subtests covering install status/ordering, coexistence with concurrent activities, category/label/team scoping, and multi-host scenarios. Corresponding import and spacing adjustments were made in server/service/integration_enterprise_test.go with no logic changes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: moving a flaky integration test to stop MDM flag leakage from breaking other tests.
Description check ✅ Passed It covers the fix and testing, though the related-issue placeholder still needs a real issue number or NA.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-vpp-install-all-suite-test

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.44.1)
server/service/integration_mdm_test.go

ast-grep timed out on this file


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jkatz01 jkatz01 requested a review from nulmete July 8, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant