Fix Corners Not Removed When Maximised and in Fullscreen - #105
Merged
Conversation
A window can be both both maximized and in fullscreen at the same time. So we only need to use the maximize config when we are explicitly only maximized.
Owner
|
@SnoutBug LGTM, I fixed the CI checks, could you please rebase this onto main to re-run them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is described in #104.
This issue appears because:
This PR fixes this by addressing 1. in the event_manager, listening explicitly to the full screen event and 2. by fixing the logic determining whether or not the window should receive rounded corners.
This closes #104.