Draft
Conversation
marc-flex
reviewed
Dec 16, 2025
Contributor
marc-flex
left a comment
marc-flex
left a comment
There was a problem hiding this comment.
This is a fantastic feature!
Comment on lines
+2072
to
+2078
| try: | ||
| normal_axis = self._get_normal_axis() | ||
| except SetupError: | ||
| log.warning( | ||
| "Automatic doping refinement is only supported for 2D simulations. " | ||
| "Skipping auto refinement." | ||
| ) |
Contributor
There was a problem hiding this comment.
Since _get_normal_axis() already raises a SetupError what would this warning accomplish?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.