Skip to content

fix sbt-projectmatrix mixing dependency#348

Merged
novakov-alexey merged 3 commits intoflink-extended:masterfrom
DataDome-OSS-contrib:fix-mixed-dependency
Feb 23, 2026
Merged

fix sbt-projectmatrix mixing dependency#348
novakov-alexey merged 3 commits intoflink-extended:masterfrom
DataDome-OSS-contrib:fix-mixed-dependency

Conversation

@arnaud-daroussin
Copy link
Copy Markdown
Contributor

@arnaud-daroussin arnaud-daroussin commented Feb 23, 2026

Hi @novakov-alexey,

sbt-projectmatrix is quite new for me, so its usage is still uncertain. But it should to do the trick to fix the dependency issue in #320.

Actually, it seems logical. flink-1-api and flink-2-api projects were referencing flink (-common) project but nothing was telling them to pick Flink1 or Flink2 variations of this project, so both were picking arbitrarily the first variation Flink1.

The fix consists to specify the correct "Flink" axis to both sub-project in addition to JVM axis.

Now each project is picking the correct parent dependency. I checked all produced pom and they are good.

And by tweaking FlinkAxis a bit more, I'm able to keep a "fair enough" project IDs naming:

sbt projects
[info]     docs
[info]     docs3
[info]     examples3
[info]     flink-1-api
[info]     flink-1-api-common
[info]     flink-1-api-common3
[info]     flink-1-api3
[info]     flink-2-api
[info]     flink-2-api-common
[info]     flink-2-api-common3
[info]     flink-2-api3
[info]   * flink-scala-api

@novakov-alexey
Copy link
Copy Markdown
Collaborator

Thanks for the PR.

@novakov-alexey novakov-alexey merged commit 64667e7 into flink-extended:master Feb 23, 2026
9 checks passed
@arnaud-daroussin arnaud-daroussin deleted the fix-mixed-dependency branch February 23, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants