fix sbt-projectmatrix mixing dependency#348
Merged
novakov-alexey merged 3 commits intoflink-extended:masterfrom Feb 23, 2026
Merged
fix sbt-projectmatrix mixing dependency#348novakov-alexey merged 3 commits intoflink-extended:masterfrom
novakov-alexey merged 3 commits intoflink-extended:masterfrom
Conversation
a033911 to
c8667f2
Compare
Collaborator
|
Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @novakov-alexey,
sbt-projectmatrix is quite new for me, so its usage is still uncertain. But it should to do the trick to fix the dependency issue in #320.
Actually, it seems logical.
flink-1-apiandflink-2-apiprojects were referencingflink(-common) project but nothing was telling them to pick Flink1 or Flink2 variations of this project, so both were picking arbitrarily the first variation Flink1.The fix consists to specify the correct "Flink" axis to both sub-project in addition to JVM axis.
Now each project is picking the correct parent dependency. I checked all produced pom and they are good.
And by tweaking
FlinkAxisa bit more, I'm able to keep a "fair enough" project IDs naming: