perf(core): validate out-of-lint-set cache dependencies by timestamp - #3253
Open
JoshuaKGoldberg wants to merge 4 commits into
Open
perf(core): validate out-of-lint-set cache dependencies by timestamp#3253JoshuaKGoldberg wants to merge 4 commits into
JoshuaKGoldberg wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 5449ead The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for flint-fyi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
JoshuaKGoldberg
marked this pull request as ready for review
August 21, 2026 20:10
JoshuaKGoldberg
requested review from
lishaduck and
michaelfaith
and removed request for
michaelfaith
August 29, 2026 18:55
michaelfaith
approved these changes
Aug 29, 2026
michaelfaith
left a comment
michaelfaith
left a comment
Member
There was a problem hiding this comment.
Looks good! Just a couple minor nits.
| const host = createDiskBackedLinterHost(integrationRoot); | ||
| const missingPath = path.join(integrationRoot, "missing.txt"); | ||
|
|
||
| expect(await host.getFileTouchTime(missingPath)).toEqual(undefined); |
Member
There was a problem hiding this comment.
https://vitest.dev/api/expect.html#tobeundefined
Suggested change
| expect(await host.getFileTouchTime(missingPath)).toEqual(undefined); | |
| expect(await host.getFileTouchTime(missingPath)).toBeUndefined(); |
| const host = createDiskBackedLinterHost(integrationRoot); | ||
| const missingPath = path.join(integrationRoot, "missing.txt"); | ||
|
|
||
| expect(host.getFileTouchTimeSync(missingPath)).toEqual(undefined); |
Member
There was a problem hiding this comment.
Suggested change
| expect(host.getFileTouchTimeSync(missingPath)).toEqual(undefined); | |
| expect(host.getFileTouchTimeSync(missingPath)).toBeUndefined(); |
michaelfaith
added
the
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
For file paths outside the lint set, we now do a touch timestamp check on the file itself using
stat. Touch times are cached so it's at most one per file.Also two small fixes as a part of this:
continueinside the dependency loop continued the inner loop rather than moving to the next file, somarkAsUncachedcould fire repeatedly for one file and the file's own timestamp check still ran after it had already been invalidated. The dependency scan is now a helper that returns a boolean, so the outer loop cancontinueproperly.createDiskBackedLinterHost'sgetFileTouchTime/getFileTouchTimeSyncthrew when a file did not exist, even though both are typed as returningnumber | undefined(the VFS host already returnsundefined). They now returnundefined, which is what lets a deleted dependency be treated as changed instead of crashing the run.❤️🔥