Added patch to throw exception in afterExecute and beforeExecute#41
Open
nottocode wants to merge 3 commits into
Open
Added patch to throw exception in afterExecute and beforeExecute#41nottocode wants to merge 3 commits into
nottocode wants to merge 3 commits into
Conversation
| logger.error("Error running pre-execution execution listener: ", t); | ||
| final String errorMessage = "Error running pre-execution execution listener: "; | ||
| logger.error(errorMessage, t); | ||
| if (listener.shouldThrowExceptionInBeforeExecute()) { |
There was a problem hiding this comment.
Exact same code is getting repeated at three places. Create a method like, handleExceptionInBeforeExecute() in utils and use that at all the places.
Same can be done for afterExecute as well.
| final String errorMessage = "Error running post-execution execution listener: "; | ||
| logger.error(errorMessage, t); | ||
| if (listener.shouldThrowExceptionInAfterExecute()) { | ||
| throw new DataBuilderFrameworkException(DataBuilderFrameworkException.ErrorCode.BUILDER_POST_EXECUTION_ERROR, |
There was a problem hiding this comment.
Add test cases for both the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.