refactor: separate config path acquisition to getConfigPath() function
#2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract config path logic to separate `getConfigPath()` function. - Simplify config priority handling: cmd flag > env variable > default by mode. - Remove unnecessary param `path` for `viper()` function.
- Use specific config files for debug mode. - Add fallback to default config path when mode-specific config file doesn't exist. - Enhance error messages with better formatting and wrapping: * Error strings should not end with punctuation or newlines. * Error strings should not be capitalized, refer to https://go.dev/wiki/CodeReviewComments#error-strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getConfigPath()function.pathforviper()function.