New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cleanup) redis-namespace no longer works #918

Merged

jnunemaker merged 1 commit into flippercloud:main from joshgoebel:no-more-namespacing

Mar 11, 2025

joshgoebel commented Mar 9, 2025 •

edited

Loading

Via #719:

redis namespace is no longer needed thanks to #722.

And it no longer appears to work. The flipper-redis gem's use of with seems to bypass the namespacing provided by redis-namespace entirely:

irb(main):037> r
=> <Redis::Namespace v1.11.0 with client v4.8.1 for redis://redis:6379/0/cmm:namespace>
irb(main):038> c
=> #<Redis client v4.8.1 for redis://redis:6379/0>
irb(main):039> r.set("one", true)
=> "OK"
irb(main):041> r.with { |c| c.set("two","true") }
=> "OK"
irb(main):042> c.keys
=>
[
 "two",
 "cmm:namespace:one"
]

Am I missing something?


          (cleanup) redis-namespace no longer works

96954c3

jnunemaker merged commit b16e355 into flippercloud:main

46 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet