Skip to content

feat(oidc): add discovery_url override and claims_mapping for OIDC pr… - #6233

Draft
montaro wants to merge 2 commits into
flipt-io:v2from
montaro:feat/oidc-discovery-url
Draft

feat(oidc): add discovery_url override and claims_mapping for OIDC pr…#6233
montaro wants to merge 2 commits into
flipt-io:v2from
montaro:feat/oidc-discovery-url

Conversation

@montaro

@montaro montaro commented Jul 21, 2026

Copy link
Copy Markdown

…oviders [WIP]

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @montaro! Thanks for your contribution to this project.

It looks like one or more of your commits are missing a DCO (Developer Certificate of Origin) sign-off. The DCO is a simple way for you to certify that you have the right to submit this code under the project's license.

How to fix this:

# For future commits, use the -s flag
git commit -s -m "Your commit message"

# To sign off on existing commits in this PR
git rebase HEAD~$(git rev-list --count origin/v2..HEAD) --signoff
git push --force-with-lease

The -s flag adds this line to your commit message:
Signed-off-by: Your Name <your.email@example.com>

📋 View the failing DCO check for more details

For more information about the DCO, visit: https://developercertificate.org/

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: approve

Clean, well-tested auth change. The discovery_url override correctly uses go-oidc's InsecureIssuerURLContext while pinning token verification to issuer_url, and claims_mapping handles arrays, missing values, and non-strings properly. No code issues found. (Note: the PR is still marked [WIP] and the DCO check is failing — commits need sign-offs.)

🤖 Automated review by the Flipt PR review agent.

@erka erka added the v2 Flipt v2 label Jul 23, 2026
@erka erka added the needs docs Requires documentation updates label Jul 23, 2026
montaro and others added 2 commits July 23, 2026 23:16
It moves from parsing JSON pointer expressions on every
applyMapping call to compiling them once in newClaimsMapping
during newOIDCClient, with config-time validation and debug
logging for resolution failures.

Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka
erka force-pushed the feat/oidc-discovery-url branch from 65b7ab4 to 2b76f70 Compare July 23, 2026 23:19
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.45%. Comparing base (b7aec53) to head (2b76f70).
⚠️ Report is 12 commits behind head on v2.

Files with missing lines Patch % Lines
internal/config/authentication.go 71.42% 1 Missing and 1 partial ⚠️
internal/server/authn/method/oidc/server.go 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #6233      +/-   ##
==========================================
+ Coverage   62.41%   62.45%   +0.04%     
==========================================
  Files         145      145              
  Lines       14867    14910      +43     
==========================================
+ Hits         9279     9312      +33     
- Misses       4828     4836       +8     
- Partials      760      762       +2     
Flag Coverage Δ
integrationtests 33.28% <0.00%> (-0.16%) ⬇️
unittests 54.09% <92.15%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs docs Requires documentation updates v2 Flipt v2

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants