fix: 🐛 more than four individuals causing colors to be incorrect #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
individual data structure had two color fields in it, and object colors, such as the UI config gerjneates, were not being moved from one to the other so they were missed. The list of entities passed to the style function to generate the CSS colors for the individual entities was not sorted first, so when that option was selected the wrong entities would be used for color selection. That function was also processing the entire list of individual entities when only up to four are needed.
TypeScript is new to me and I am also rather rusty in general, so review of this would be appreciated.