Skip to content

Fix a bug which broke the battery charging flow from solar #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix a bug which broke the battery charging flow from solar #833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21e3c21
Fix a bug which broke the battery charging flow from solar
re-ynd Jun 8, 2025
5715362
The correct fix after checking in with a user who reported the bug
re-ynd Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/power-flow-card-plus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,10 +354,17 @@ export class PowerFlowCardPlus extends LitElement {
}
}
solar.state.toHome = 0;
} else if (solar.state.toHome !== null && solar.state.toHome > 0) {
} else if (battery.state.toBattery !== null && battery.state.toBattery > 0) {
// Battery is being charged, but by what (grid or solar) and by how much?
// Solar is charging battery with any power left over after powering the
// home and sending to grid
solar.state.toBattery = solar.state.total - (solar.state.toHome || 0) - (grid.state.toGrid || 0);

// Grid is providing any left over battery charging power after
// compensating for the solar charging
grid.state.toBattery = battery.state.toBattery - solar.state.toBattery;
} else {
grid.state.toBattery = 0;
} else if (battery.state.toBattery && battery.state.toBattery > 0) {
grid.state.toBattery = battery.state.toBattery;
}
grid.state.toBattery = (grid.state.toBattery ?? 0) > largestGridBatteryTolerance ? grid.state.toBattery : 0;

Expand Down