feat: show attachment file sizes#1252
Merged
andrinoff merged 3 commits intofloatpane:masterfrom May 8, 2026
Merged
Conversation
floatpanebot
added
area/tui
Contributor
Author
|
Closes #550 |
Member
add it to description, please. |
andrinoff
requested changes
May 8, 2026
Member
|
i'll check how it looks in the evening. |
Member
|
/approve |
floatpanebot
approved these changes
May 8, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Approved on behalf of @andrinoff via /approve command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #550
What?
Display attachment file sizes in the composer attachment list, e.g.
image.jpg (1.2 MB).Also wired file size formatting through the existing i18n number formatter:
GetNumberFormatter()to the i18n managertfs(...)Why?
Composer previously showed only attachment filenames, so users had no quick way to check file size before sending.
The formatter was touched because there was already an unused locale-aware
i18n.NumberFormatter.FormatFileSize. Instead of keeping a composer-specific helper or reusing a file picker-private function, this change makes file size formatting a shared i18n-backed path. That keeps formatting consistent across TUI components and supports locale-specific number formatting, such as1.2 MBvs1,2 MB.