fix(native): register Cloud Scheduler and Monitoring protos for native-image reflection#66
Merged
Merged
Conversation
…e-image reflection floci-gcp depends on the gRPC stubs (grpc-google-cloud-scheduler-v1, grpc-google-cloud-monitoring-v3), not the GAPIC client libraries that ship reflect-config.json, so the proto message classes were not registered for native-image reflection. In native builds this broke: - Cloud Scheduler REST (gcloud): "Invalid protobuf JSON: Generated message class com.google.cloud.scheduler.v1.Job missing method getName". - Cloud Monitoring CreateTimeSeries: com.google.monitoring.v3.TypedValue missing getBoolValue() -> StatusRuntimeException INTERNAL. Add the SDK's authoritative reflect-config.json for com.google.cloud.scheduler.v1 and com.google.cloud.monitoring.v3 under META-INF/native-image, so GraalVM registers the message graphs. JVM builds were unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registers the SDK reflect-config for
com.google.cloud.scheduler.v1andcom.google.monitoring.v3underMETA-INF/native-image. floci-gcp depends on the gRPC stubs (grpc-google-cloud-scheduler-v1,grpc-google-cloud-monitoring-v3), not the GAPIC client libraries that shipreflect-config.json, so these proto message classes weren't registered for GraalVM native-image reflection.Type of change
fix:)feat:)feat!:orfix!:)GCP Compatibility
Native-image only; no wire-protocol change. In native builds this broke:
Invalid protobuf JSON: Generated message class com.google.cloud.scheduler.v1.Job missing method getName.CreateTimeSeries:com.google.monitoring.v3.TypedValue missing getBoolValue()→StatusRuntimeException INTERNAL.Verified against the native binary: the
sdk-test-gcloudscheduler cases andMonitoringTestnow pass. JVM/CI was unaffected (thejava.sql-style ServiceLoader/reflection is present on the JVM).Checklist
./mvnw testpasses locally