test(stepfunctions): fix AslExecutorPathIntrinsicsTest compile against ecs:runTask ctor#1696
test(stepfunctions): fix AslExecutorPathIntrinsicsTest compile against ecs:runTask ctor#1696abanna wants to merge 2 commits into
Conversation
…rinsicsTest AslExecutor gained EcsService and EcsJsonHandler constructor parameters with the ecs:runTask service integration (floci-io#1564), but AslExecutorPathIntrinsicsTest (added in floci-io#1558) was not updated to pass them. As a result the test sources no longer compile on main. Pass the two missing mocks, matching the sibling AslExecutor tests.
|
| Filename | Overview |
|---|---|
| src/test/java/io/github/hectorvent/floci/services/stepfunctions/AslExecutorPathIntrinsicsTest.java | Adds the two missing ECS mocks to the AslExecutor constructor call; parameter order matches the production constructor exactly and is consistent with sibling test classes. |
Reviews (1): Last reviewed commit: "test(stepfunctions): pass ecs:runTask ct..." | Re-trigger Greptile
Problem
The test sources on
mainno longer compile.AslExecutorgainedEcsServiceandEcsJsonHandlerconstructor parameters with the ecs:runTask service integration (#1564), butAslExecutorPathIntrinsicsTest(added in #1558) was never updated to pass them. Because MaventestCompileis all-or-nothing, this breaks the whole test compilation — and therefore CI — onmainand on every open PR.Fix
Pass the two missing mocks (
EcsService,EcsJsonHandler) in the constructor call, in the same position and style as the siblingAslExecutortests (e.g.AslExecutorCatchTest,AslExecutorEcsRunTaskModeTest). No production code changes.Verification
Built and ran the affected test in a JDK 25 container:
AslExecutorPathIntrinsicsTest— 13 tests, all pass.