Skip to content

test(stepfunctions): fix AslExecutorPathIntrinsicsTest compile against ecs:runTask ctor#1696

Open
abanna wants to merge 2 commits into
floci-io:mainfrom
abanna:fix/stepfunctions-aslexecutor-test-compile
Open

test(stepfunctions): fix AslExecutorPathIntrinsicsTest compile against ecs:runTask ctor#1696
abanna wants to merge 2 commits into
floci-io:mainfrom
abanna:fix/stepfunctions-aslexecutor-test-compile

Conversation

@abanna

@abanna abanna commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Problem

The test sources on main no longer compile. AslExecutor gained EcsService and EcsJsonHandler constructor parameters with the ecs:runTask service integration (#1564), but AslExecutorPathIntrinsicsTest (added in #1558) was never updated to pass them. Because Maven testCompile is all-or-nothing, this breaks the whole test compilation — and therefore CI — on main and on every open PR.

constructor AslExecutor in class ...AslExecutor cannot be applied to given types;
  required: ...,S3Service,EcsService,EcsJsonHandler,ObjectMapper,...
  found:    ...,S3Service,ObjectMapper,...
  reason: actual and formal argument lists differ in length

Fix

Pass the two missing mocks (EcsService, EcsJsonHandler) in the constructor call, in the same position and style as the sibling AslExecutor tests (e.g. AslExecutorCatchTest, AslExecutorEcsRunTaskModeTest). No production code changes.

Verification

Built and ran the affected test in a JDK 25 container: AslExecutorPathIntrinsicsTest — 13 tests, all pass.

…rinsicsTest

AslExecutor gained EcsService and EcsJsonHandler constructor parameters with
the ecs:runTask service integration (floci-io#1564), but AslExecutorPathIntrinsicsTest
(added in floci-io#1558) was not updated to pass them. As a result the test sources no
longer compile on main. Pass the two missing mocks, matching the sibling
AslExecutor tests.
@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes a compile-time breakage in AslExecutorPathIntrinsicsTest caused by the AslExecutor constructor gaining two new parameters (EcsService, EcsJsonHandler) in #1564, while the test class added in #1558 was never updated. No production code is changed.

  • Adds mock(EcsService.class) and mock(EcsJsonHandler.class) as the 9th and 10th constructor arguments in the setUp() method, in the exact positions required by the AslExecutor constructor signature, consistent with the existing sibling tests (AslExecutorCatchTest, AslExecutorEcsRunTaskModeTest).

Confidence Score: 5/5

Safe to merge — test-only change that restores compilation with no risk to production behaviour.

The change is a two-line addition of mock arguments in a single test setup method. The argument positions match the production constructor exactly and are consistent with every other sibling test class. All 13 tests in the file pass, and no production code is touched.

No files require special attention.

Important Files Changed

Filename Overview
src/test/java/io/github/hectorvent/floci/services/stepfunctions/AslExecutorPathIntrinsicsTest.java Adds the two missing ECS mocks to the AslExecutor constructor call; parameter order matches the production constructor exactly and is consistent with sibling test classes.

Reviews (1): Last reviewed commit: "test(stepfunctions): pass ecs:runTask ct..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant