feat: emit jti/origin_jti and support RevokeToken#1705
Open
AbhigyaKrishna wants to merge 2 commits into
Open
Conversation
…g check Address PR review feedback on the jti/origin_jti + RevokeToken change: - RevokeToken now validates the client secret before the EnableTokenRevocation check, so a confidential client with revocation disabled returns NotAuthorizedException (not UnsupportedOperationException) for a wrong/missing secret, matching AWS's identity-first ordering and avoiding leaking revocation state to unauthenticated callers. - OriginJtiIntegrationTest guards the shared ordered-test state via requireSetup()/requireInitialAuthState() so a setup or initial-auth failure reports a clear cause instead of misleading downstream assertions, and adds a regression test for the auth-ordering fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings Floci's Cognito token generation to parity with real AWS Cognito by emitting the two native token-revocation claims and honoring the RevokeToken API. Implements the Sapphire Terminal team's patch request (floci-patch-origin-jti-request.md) that unblocks end-to-end dev testing of "remote device logout" (instant session revocation).
origin_jti and the refresh token's embedded id was unrelated — breaking the stable-across-refresh contract downstream authorizers rely on.
Type of change
AWS Compatibility
Checklist