Repository navigation
Add job presets - #125
Open
floriandejonckheere wants to merge 4 commits into
Open
Add job presets#125floriandejonckheere wants to merge 4 commits into
floriandejonckheere wants to merge 4 commits into
Conversation
Foreman runs as PID 1 and shuts down all processes when an orphaned process (e.g. Chrome spawned by system specs) is reparented to it and exits. An init process reaps these orphans instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds presets: sets of recommended rsync options for common use cases, defined in
JobPreset(app/objects/job_preset.rb).--dry-run --itemize-changesand keeps the other options.init: trueincompose.yml. Foreman ran as PID 1 and shut the container down whenever an orphaned process (e.g. Chrome spawned by system specs run viadocker compose exec) exited.Not included (tracked in
docs/PROJECT.md): the Borg lock-check pre-hook (needs a{source_path}hook variable and only works for local sources), and dated--backup-dirdirectories for the previous versions preset.Testing
bundle exec rspecandbundle exec rspec spec/system(new:spec/objects/job_preset_spec.rb,spec/system/jobs/presets_spec.rb, preset step inspec/requests/job_wizards_request_spec.rb)docker compose up -d app worker) to pick upinit: true