Draft: Hobycase with single vertical wall#930
Draft
bofakin wants to merge 2 commits into
Draft
Conversation
bofakin
force-pushed
the
hobycase-single-vertical
branch
from
c247638 to
8fd2bb4
Compare
bofakin
force-pushed
the
hobycase-single-vertical
branch
from
8fd2bb4 to
43195ca
Compare
bofakin
changed the title
Author
|
I somehow messed up the first push - some changed were missing there. Now everything should be up there. Sorry for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hobbycase is extended to allow to be build with only a single vertical wall.
To support all shelve positions combinations a TriFingerJoint edge is introduced. It has double length holes and the finger on its edges are organised to always fit the left or right side of an hole. This allow to insert such edges from both sides.
The changes to the Hobbycase are controlled by an new parameter which selects between the classic behaviour and the single wall mode. In single wall mode, the double width holes are changed to single width and the number of vertical walls is reduced.
Current State: The generated files look good, but I have neither printed such a case nor assembled one in a 3D construction tool. The MR is mostly for early feedback to have everything ready for merge when the physical tests succeed.