filter tag: enforce bans during parsing - #384
Open
codexagents wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{% filter %}tag filters when the template is parsedTemplateSet.BanFilterregistry on that syntaxWhy
Expression filters are checked against
bannedFiltersand bound during parsing. The filter tag currently stores only a name and callsTemplateSet.ApplyFilterat execution time; that API intentionally looks only at the filter registry, so{% filter random %}still executes afterBanFilter("random").Binding the function in the tag parser closes that sandbox bypass and makes both filter syntaxes follow the same lifecycle.
Verification
go test ./...go test -race ./...go vet ./...