remove specify internal edgestarts #606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AboudyKreidieh
requested review from
cathywu,
eugenevinitsky and
kanaadp
as code owners
AboudyKreidieh
changed the title
…move_specify_internal_edgestarts
|
I suppose let me know when this nightmare is ready for review? 70 files changed my god. |
…move_specify_internal_edgestarts
…move_specify_internal_edgestarts
…move_specify_internal_edgestarts
AboudyKreidieh
changed the title
Pull Request Test Coverage Report for Build 4977
💛 - Coveralls |
…move_specify_internal_edgestarts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request information
Description
This PR removes the
specify_internal_edgestartsfeatures, and instead computes the the positions of junctions instead based on the predefined positions of edges. The positions of junctions of the scenarios that use this feature were validated.Update: when computing starting positions, the
gen_starting_positionsmethod no longer uses the lengths of junctions.