Jit.plotter: fix modifier parsing after c74 update #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balintlaczko
changed the title
Contributor
Author
|
Take that, git! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, so how about now? Looks pretty clean. :))
The only change was changing a
commentin the main patch fromto
and the
p handle_mousesubpatch to this:The problem was that c74 included new values reported from the
jit.pwindowwhen mousing, and that broke my modifier parsing logic (because I used to slice the list from behind, because ctrl[mac] used to be the last element). So I just needed to parse it slightly differently. Now I am usingunpackwhich seems to ignore lists that are longer than prescribed, so, unless they will change the order, this won't break again, even if they keep adding new things to the list.