sds: preserve input when printf growth fails - #82
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
marked this pull request as ready for review
July 11, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the original SDS terminator before
cfl_sds_printf()attempts togrow its buffer.
Background
vsnprintf()writes a truncated result when the available capacity isinsufficient. If the subsequent allocation failed,
cfl_sds_printf()returnedNULLwhile leaving bytes beyond the recorded SDS length modified and theterminator invariant broken.
The original terminator is now restored before growth and on formatting
errors, so failure leaves the input SDS valid and unchanged from the caller's
perspective.
A regression test also covers appending formatted content to an existing
prefix while the SDS grows.
Validation
git diff --check