-
Notifications
You must be signed in to change notification settings - Fork 544
release: update to v4.1.2 #2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request adds two new Docker tag entries (versions 4.1.2-debug and 4.1.2) to the installation downloads documentation, each supporting multiple architectures (x86_64, arm64v8, arm32v7, s390x). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
installation/downloads/docker.md(1 hunks)installation/downloads/windows.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
installation/downloads/windows.md
[grammar] ~131-~131: Use a hyphen to join words.
Context: ... These are now using the Github Actions built versions. Legacy AppVeyor builds a...
(QB_NEW_EN_HYPHEN)
🔇 Additional comments (1)
installation/downloads/windows.md (1)
116-116: Clarify version consistency with Docker documentation.Line 116 states "The latest stable version is 4.1.2," but the Docker documentation (sister file) lists 4.2.0 as a released version. If 4.2.0 is the true latest stable release, this should be updated to reflect that. If 4.1.2 is intentionally the latest for Windows only, consider adding a clarifying note (e.g., "The latest stable version for Windows is 4.1.2").
Signed-off-by: Hiroshi Hatake <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
f2a32b0 to
780309b
Compare
|
@cosmo0920 should this target 4.1 branch or something in docs? |
|
Yeah, I'm not doing 4.1.2 tags for docs... just part of the 4.1. |
Update release 4.1.2 version.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.