-
Notifications
You must be signed in to change notification settings - Fork 544
Note that envvar cannot be used in include section #2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Warning Rate limit exceeded@jimin9038 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 21 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdded a documentation clarification to the Fluent Bit YAML includes section: environment variables are not supported there and included file paths must be literal string values. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
administration/configuring-fluent-bit/yaml/includes-section.md (1)
29-30: Consider adding a reference link to guide users toward workarounds.The clarification accurately states that environment variables aren't supported in the includes section. However, per the PR objectives, a link to the referenced issue (fluent/fluent-bit#2020) should be included to help users discover workaround discussions.
Apply this diff to add context for users seeking alternatives:
-Environment variables are not supported in includes section. The file path must be specified as a literal string. +Environment variables are not supported in includes section. The file path must be specified as a literal string. For workaround discussions, see [this issue](https://github.com/fluent/fluent-bit/issues/2020).
88b73b5 to
8a75226
Compare
Signed-off-by: Jimin Ha <[email protected]>
|
@eschabell Hi, this is not updating to reflect code changes. This describes the current limitation of Fluent Bit's configuration syntax of YAML. |
This PR is a short addition noting that environment variables cannot be used in the include section.
Some users may attempt to use environment variables in the include section and eventually run into issues - often ending up at workaround discussions such as this one: fluent/fluent-bit#2020
It would be great to add a note clarifying that the include section does not parse environment variables, and, if possible, include a link to the above issue as a reference for the workaround.
Thank you!
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.