-
Notifications
You must be signed in to change notification settings - Fork 544
in_windows_system_statistics: improve formatting in several sections of input plugin doc #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughDocumentation formatting and structure updates for the Windows System Statistics input plugin: table padding and punctuation normalized; the previous "Notes" section replaced by a Prometheus info hint block that includes Windows permission guidance and exporter reference. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–10 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@esmerel review for you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pipeline/inputs/windows-system-statistics.md (1)
5-9: Minor observation: Consider consolidating redundant information across hint blocks.Both the hint block at the introduction (lines 5-9) and the hint block at the end (lines 95-103) contain overlapping information about Windows-only status and permission requirements. While this duplication may be intentional (early warning + detailed reference after examples), you might consider whether consolidation would improve clarity. The current structure is acceptable and follows common technical documentation patterns, but monitor for potential user confusion from the repeated messages.
Also applies to: 95-103
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/inputs/windows-system-statistics.md(2 hunks)
🔇 Additional comments (2)
pipeline/inputs/windows-system-statistics.md (2)
25-30: Well-formatted metric descriptions with proper punctuation.All metric descriptions in the table now consistently end with periods, improving documentation clarity and meeting documentation standards.
95-103: Proper conversion of Notes section to structured info hint block.The hint block is well-formatted with correct opening/closing tags and appropriately integrates the "Windows only" phrasing (without hyphen) as specified in the PR objectives. The addition of the Windows Exporter Metrics plugin reference provides helpful guidance for users needing Prometheus-based metrics collection. The referenced file
windows-exporter-metrics.mdexists in the repository atpipeline/inputs/windows-exporter-metrics.md.
…of input plugin doc - Add periods to metric description sentences - Convert Notes section to info hint block - Fix "Windows-only" to "Windows only" - cleaned up duplicate warnings in hints sections Fixes fluent#2139. Signed-off-by: Eric D. Schabell <[email protected]>
fbabc4f to
a0c61a6
Compare
Fixes #2139.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.