Skip to content

Conversation

@eschabell
Copy link
Collaborator

@eschabell eschabell commented Dec 11, 2025

  • Add periods to metric description sentences
  • Convert Notes section to info hint block
  • Fix "Windows-only" to "Windows only"

Fixes #2139.

Summary by CodeRabbit

  • Documentation
    • Tightened table formatting and adjusted descriptions for CPU, Memory, Disk, and Network for clearer presentation.
    • Replaced standalone "Notes" with an informational hint referencing Windows Exporter Metrics while preserving Windows permission details.
    • Improved spacing inside the info hint for better readability.

✏️ Tip: You can customize this high-level summary in your review settings.

@eschabell eschabell requested a review from esmerel December 11, 2025 12:45
@eschabell eschabell self-assigned this Dec 11, 2025
@eschabell eschabell requested review from a team as code owners December 11, 2025 12:45
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

Walkthrough

Documentation formatting and structure updates for the Windows System Statistics input plugin: table padding and punctuation normalized; the previous "Notes" section replaced by a Prometheus info hint block that includes Windows permission guidance and exporter reference.

Changes

Cohort / File(s) Summary
Documentation formatting & notes refactor
pipeline/inputs/windows-system-statistics.md
Tightened table header/row padding; added trailing periods to CPU, Memory, Disk, and Network descriptions; removed standalone "Notes" heading and wrapped content in {% hint style="info" %} with preserved Windows permission context and a Prometheus/Windows Exporter reference; added spacing inside the hint block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Single-file documentation edits; focus review on Markdown hint syntax, punctuation consistency, and preserved content.

Possibly related PRs

Suggested labels

4.2.1

Poem

🐰 A table trimmed and tidy, neat,
Hints in boxes, spare and sweet,
Windows stats now neatly shown,
Permissions noted, exporters known.
Docs hop forward — soft and fleet.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: formatting improvements to the Windows System Statistics input plugin documentation.
Linked Issues check ✅ Passed The PR addresses issue #2139 by implementing formatting and wording improvements (periods to descriptions, Notes section conversion to info hint block) to the windows-system-statistics.md documentation file.
Out of Scope Changes check ✅ Passed All changes are scoped to formatting improvements in the windows-system-statistics.md documentation as required by the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbabc4f and a0c61a6.

📒 Files selected for processing (1)
  • pipeline/inputs/windows-system-statistics.md (2 hunks)
🔇 Additional comments (3)
pipeline/inputs/windows-system-statistics.md (3)

25-30: Metric descriptions properly punctuated.

All metric category descriptions now consistently end with periods, improving documentation consistency and readability.


5-9: Info hint block correctly replaces Notes section.

The conversion from a plain "Notes" heading to a formatted info hint block improves visual hierarchy and aligns with GitBook documentation conventions. The content clearly indicates Windows-only availability and permission requirements.


95-99: The file windows-exporter-metrics.md exists at pipeline/inputs/windows-exporter-metrics.md, so the link reference in the hint block is valid and no action is required.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell
Copy link
Collaborator Author

@esmerel review for you!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pipeline/inputs/windows-system-statistics.md (1)

5-9: Minor observation: Consider consolidating redundant information across hint blocks.

Both the hint block at the introduction (lines 5-9) and the hint block at the end (lines 95-103) contain overlapping information about Windows-only status and permission requirements. While this duplication may be intentional (early warning + detailed reference after examples), you might consider whether consolidation would improve clarity. The current structure is acceptable and follows common technical documentation patterns, but monitor for potential user confusion from the repeated messages.

Also applies to: 95-103

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb601fc and fbabc4f.

📒 Files selected for processing (1)
  • pipeline/inputs/windows-system-statistics.md (2 hunks)
🔇 Additional comments (2)
pipeline/inputs/windows-system-statistics.md (2)

25-30: Well-formatted metric descriptions with proper punctuation.

All metric descriptions in the table now consistently end with periods, improving documentation clarity and meeting documentation standards.


95-103: Proper conversion of Notes section to structured info hint block.

The hint block is well-formatted with correct opening/closing tags and appropriately integrates the "Windows only" phrasing (without hyphen) as specified in the PR objectives. The addition of the Windows Exporter Metrics plugin reference provides helpful guidance for users needing Prometheus-based metrics collection. The referenced file windows-exporter-metrics.md exists in the repository at pipeline/inputs/windows-exporter-metrics.md.

…of input plugin doc

- Add periods to metric description sentences
- Convert Notes section to info hint block
- Fix "Windows-only" to "Windows only"
- cleaned up duplicate warnings in hints sections

Fixes fluent#2139.

Signed-off-by: Eric D. Schabell <[email protected]>
@eschabell eschabell force-pushed the erics_in_win_sys_stats_fixes branch from fbabc4f to a0c61a6 Compare December 11, 2025 12:51
@eschabell eschabell added the waiting-on-review Waiting on a review from mainteners label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-review Waiting on a review from mainteners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Windows System Statistics input plugin doc

4 participants