Repository navigation
out_kafka: mitigate unbounded data races on kafka - #12817
Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Topic lookup-or-create remains mutex-protected because it requires several operations to run together.
Also fixed prefix-name routing and allocation cleanup. The four-worker regression delivered all 192 records correctly, with each dynamic topic registered once.
Verification passed:
cmake --build build -j8 ctest --test-dir build -R '^flb-rt-out_kafka$' --output-on-failure valgrind --leak-check=full --error-exitcode=1 ./build/bin/flb-rt-out_kafka /tmp/flb-kafka-venv/bin/python -m pytest tests/integration/scenarios/out_kafka -q VALGRIND=1 VALGRIND_STRICT=1 /tmp/flb-kafka-venv/bin/python -m pytest tests/integration/scenarios/out_kafka -qBoth integration runs: 31 passed, 47 skipped. Skips concern disabled encoders and unconfigured external tests. Runtime Valgrind reported zero errors. Tests used temporary Python 3.12 because the pinned Protobuf dependency fails on Python 3.14.
Closes #12814.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit