Repository navigation
tls: handle windows certstore refresh - #12824
Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Moved the Windows certificate-chain lookup off the handshake thread and limited it to one lookup per TLS context per minute, with at most one lookup in flight. Windows receives the full peer chain, including cross-signed certificates in either order. OpenSSL retains its original verification result and error queue. TLS implementation: src/tls/openssl.c:690
The first handshake still fails when its root is missing. A later connection reloads the configured store and can succeed. Outputs need retries enabled to preserve that first batch. The refresh also applies to server-side client-certificate verification. New connections pick up removed roots and exclude anchors listed in the Windows
Disallowedstore.FLB_WINDOWS_AUTO_ROOT_UPDATE=offdisables background lookups. Windows TLS documentation: docs/windows-tls.mdVerified the cold-store recovery against DigiCert’s ECC G5 endpoint. The first connection failed and scheduled one lookup. Windows installed the previously absent root in
LocalMachine\AuthRoot, and the next five verified connections succeeded.On Windows x64, both focused CTest suites and 13 integration cases passed. Coverage includes buffered delivery after issuer import, rejection after issuer removal, repeated failed handshakes with one lookup, cross-signed chain order, mutual TLS, and the opt-out. The deterministic store tests are now in the Windows x64 CI workflow. CI workflow: .github/workflows/call-windows-unit-tests.yaml:283
The two opt-in public download cases skipped on rerun because their roots were already installed.
Closes #12818.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit