Adds support for storage.type to the Kubernetes events input plugin#1853
Adds support for storage.type to the Kubernetes events input plugin#1853mob-galtryn wants to merge 7 commits intofluent:masterfrom
Conversation
Signed-off-by: Nick Galtry <nick.galtry@mobilise.cloud>
5437d70 to
05edcce
Compare
Signed-off-by: Nick Galtry <nick.galtry@mobilise.cloud>
4f3b855 to
2e78ada
Compare
Signed-off-by: Nick Galtry <nick.galtry@mobilise.cloud>
Signed-off-by: Nick Galtry <nick.galtry@mobilise.cloud>
0f12515 to
9758552
Compare
|
@joshuabaird would you mind review this PR? Seems to be pretty straightforward as it is based on existing solutions. |
| type: string | ||
| storageType: | ||
| description: Set buffering method to filesystem or memory | ||
| type: string |
There was a problem hiding this comment.
We are missing the enum here? CRDs in charts/fluent-bit-crds/templates and config/crd/bases should be autogenerated using make manifests.
There was a problem hiding this comment.
@joshuabaird I have generated the CRDs with make manifests and the enums have been added as well. Are you able to review?
Signed-off-by: Nick Galtry <nick.galtry@mobilise.cloud>
|
@mob-galtryn Thanks! Would you mind looking at the CI failures? |
|
@joshuabaird seems to be focused on docs/plugins/fluentbit/input/kubernetes_events.md, are the documents autogenerated during the pipeline? |
Can you try running |
Signed-off-by: Nick Galtry <nick.galtry@mobilise.cloud>
|
Sure I have committed the changes now |
What this PR does / why we need it:
This PR adds support for the storage.type option to the Kubernetes Events input type for Fluentbit. This will give users the ability to enable filesystem buffering for the Kuberenets Events input
Which issue(s) this PR fixes:
Fixes #1850
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: